Correct lifetime based cancellation of AsyncStream and AsyncThrowingStream #40087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
ktoso
approved these changes
Nov 11, 2021
| } | ||
| return result | ||
| } onCancel: { | ||
| storage.value = nil |
There was a problem hiding this comment.
okey and that write is lock protected... looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an outstanding issue where AsyncStream and AsyncThrowingStream could not terminate in the case of indefinite sequences for a handler that lived by capture. AsyncStream and AsyncThrowingStream now hold a context that cancels on deinitialization.
Resolves radar: rdar://82985344
Tests incoming soon.