[5.5] fix SILGen bug for cross-module actor let accesses #40100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to access a let-bound property of an actor across a moudule boundary, the operation should be treated as async. But, upon reaching SILGen, the compiler would crash when trying to emit the needed hop, because the base of the element reference was missing. This commit fixes that and adds regression coverage. resolves rdar://81812013
kavon
changed the title
kavon
added
concurrency
|
@swift-ci please test |
|
@swift-ci please nominate |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: When accessing an isolated let-bound property of an actor defined in another module, the compiler would crash.
Risk: Low
Risk Detail: This change is very small focused on avoiding an unnecessary compiler crash.
Reward: Medium
Reward Details: Without this fix, programs that import an actor from another module and try to access its isolated let-bound properties would trigger a compiler crash. Actors within the same module, or those marked
nonisolated, already work fine.Original PR: #40097
Issue: rdar://81812013
Code Reviewed By: Doug Gregor
Testing Details: Regression test is included.