[Frontend] Load standard libarary in CompilerInstance::setup #40107
Conversation
|
@swift-ci Please smoke test |
ahoppen
force-pushed
the
pr/load-stdlib-in-setup
branch
3 times, most recently
from
a42c090 to
f9e0aae
Compare
|
@swift-ci Please smoke test |
| case FrontendOptions::ActionType::ScanDependencies: | ||
| requestedAction = Opts.RequestedAction; | ||
| break; |
There was a problem hiding this comment.
@nkcsgexi @artemcm Does this look good to you?
Would you mind also double checking that there aren't other callers of CompilerInstance::setup where we may need to change the requested action to avoid loading the stdlib? In particular I'm not too sure what frontend arguments are being fed for the other dependency scanning call-sites, are they guaranteed to use the dependency scanning action?
There was a problem hiding this comment.
This looks fine to me.
I also fully expect all dependency scanning call-sites to also have FrontendOptions::ActionType::ScanDependencies.
| case FrontendOptions::ActionType::ScanDependencies: | ||
| requestedAction = Opts.RequestedAction; | ||
| break; |
There was a problem hiding this comment.
This looks fine to me.
I also fully expect all dependency scanning call-sites to also have FrontendOptions::ActionType::ScanDependencies.
ahoppen
force-pushed
the
pr/load-stdlib-in-setup
branch
from
f9e0aae to
599b32e
Compare
|
@swift-ci Please smoke test |
Instead of checking that the stdlib can be loaded in a variety of places, check it when setting up the compiler instance. This required a couple more checks to avoid loading the stdlib in cases where it’s not needed. To be able to differentiate stdlib loading failures from other setup errors, make `CompilerInstance::setup` return an error message on failure via an inout parameter. Consume that error on the call side, replacing a previous, more generic error message, adding error handling where appropriate or ignoring the error message, depending on the context.
…piler invocation Explicitly specify the frontend action to make sure we aren’t loading thes stdlib if the performed action is syntactic only.
ahoppen
force-pushed
the
pr/load-stdlib-in-setup
branch
from
599b32e to
22f67e8
Compare
|
@swift-ci Please smoke test |
Instead of checking that the stdlib can be loaded in a variety of places, check it when setting up the compiler instance. This required a couple more checks to avoid loading the stdlib in cases where it’s not needed.
To be able to differentiate stdlib loading failures from other setup errors, make
CompilerInstance::setupreturn an error message on failure via an inout parameter. Consume that error on the call side, replacing a previous, more generic error message, adding error handling where appropriate or ignoring the error message, depending on the context.Was discussed in #39631 (comment)