[CSApply/Distributed] Identify implicitly throwing calls while applying solution #40130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
commented
Nov 10, 2021
xedin
force-pushed
the
rdar-83610106-with-locals
branch
from
0e71a98 to
90b0079
Compare
|
@swift-ci please clean test |
xedin
changed the title
DougGregor
reviewed
Nov 12, 2021
There was a problem hiding this comment.
This is a great direction. I think we're going to need to pull more information into the constraint system to get actor-isolation checking working properly for closures when isolation is queried from inside the constraint solver like this; see my comments inline.
It's useful not only inside of isolation checking but in the type-checker as well.
…stributed thunk Make it possible for type-checker to determine whether the given reference in the given context represents a call to a remote distributed actor.
Use newly added `isDistributedThunk` check to determine whether the given call is to a remote distributed actor and if so mark it as implicitly throwing. Resolves: rdar://83610106
…itter This logic cannot live in `ActorIsolationChecker` because all of the relevant information is only accessible through constraint system while applying solutions.
…nger useful `ConstraintSystem` has its own method to determine this.
xedin
force-pushed
the
rdar-83610106-with-locals
branch
from
90b0079 to
70360eb
Compare
DougGregor
approved these changes
Nov 13, 2021
|
@swift-ci please clean test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
|
Awesome! And CI green everywhere as well now 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to distributed actor methods could be pointing to a thunk for remote access,
such thunks are implicitly throwing. Their existence has to be identified early in order
for later steps of solution application to mark context as throwing e.g. implicitly
generated autoclosures for
async letinitializers rely on that to make closure asthrowing when necessary.
Resolves: rdar://83610106