Skip to content

[gardening] add public SR bug number to supplement rdar link #40138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2021
Merged

[gardening] add public SR bug number to supplement rdar link #40138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions stdlib/public/core/Sort.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ internal func _merge<Element>(
}
}

// FIXME: Remove this, it works around rdar://problem/45044610
// FIXME: Remove this, it works around SR-14750 (rdar://45044610)
return true
}

Expand Down Expand Up @@ -534,7 +534,7 @@ extension UnsafeMutableBufferPointer {
runs[i - 1] = low..<high
runs.remove(at: i)

// FIXME: Remove this, it works around rdar://problem/45044610
// FIXME: Remove this, it works around SR-14750 (rdar://45044610)
return result
}

Expand Down Expand Up @@ -571,7 +571,7 @@ extension UnsafeMutableBufferPointer {
// If W > X + Y, X > Y + Z, and Y > Z, then the invariants are satisfied
// for the entirety of `runs`.

// FIXME: Remove this, it works around rdar://problem/45044610
// FIXME: Remove this, it works around SR-14750 (rdar://45044610)
var result = true

// The invariant is always in place for a single element.
Expand Down Expand Up @@ -626,7 +626,7 @@ extension UnsafeMutableBufferPointer {
buffer: UnsafeMutablePointer<Element>,
by areInIncreasingOrder: (Element, Element) throws -> Bool
) rethrows -> Bool {
// FIXME: Remove this, it works around rdar://problem/45044610
// FIXME: Remove this, it works around SR-14750 (rdar://45044610)
var result = true
while runs.count > 1 {
result = try result && _mergeRuns(
Expand All @@ -651,7 +651,7 @@ extension UnsafeMutableBufferPointer {
return
}

// FIXME: Remove this, it works around rdar://problem/45044610
// FIXME: Remove this, it works around SR-14750 (rdar://45044610)
var result = true

// Use array's allocating initializer to create a temporary buffer---this
Expand Down Expand Up @@ -695,7 +695,7 @@ extension UnsafeMutableBufferPointer {
_internalInvariant(runs.count == 1, "Didn't complete final merge")
}

// FIXME: Remove this, it works around rdar://problem/45044610
// FIXME: Remove this, it works around SR-14750 (rdar://45044610)
_precondition(result)
}
}