Skip to content

[lit] Apply a different label for tests under validation-test/ than the ones under test/ #40146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

lorentey
Copy link
Member

This will let us find the test file that produced a failure on the first attempt, saving the project at least three trillion cumulative person-seconds each year. 🙃

…he ones under test/

This will let us find the test file that produced a failure on the first attempt, saving the project at least three trillion cumulative person-seconds each year.
@lorentey
Copy link
Member Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8c3a8e7

@lorentey
Copy link
Member Author

21:14:25 Test Suite 'Selected tests' started at 2021-11-11 21:12:38.990
21:14:25 Test Suite 'SwiftPMPackageTests.xctest' started at 2021-11-11 21:12:38.991
21:14:25 Test Suite 'PackageCollectionsStorageTests' started at 2021-11-11 21:12:38.991
21:14:25 Test Case '-[PackageCollectionsTests.PackageCollectionsStorageTests testListNonBatching]' started.
21:14:25 
21:14:25 Exited with signal code 6

@lorentey
Copy link
Member Author

@swift-ci test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8c3a8e7

@lorentey
Copy link
Member Author

13:24:59 /Users/buildnode/jenkins/workspace/swift-PR-macos/branch-main/swift-docc/Sources/SwiftDocC/Infrastructure/Symbol Graph/SymbolGraphRelationshipsBuilder.swift:145:45: error: referencing operator function '==' on 'StringProtocol' requires that 'SymbolGraph.Symbol.KindIdentifier' conform to 'StringProtocol'
13:24:59         if conformingSymbol.kind.identifier == SymbolGraph.Symbol.Kind.Swift.protocol.rawValue {
13:24:59                                             ^
13:24:59 Swift.StringProtocol:1:11: note: where 'Self' = 'SymbolGraph.Symbol.KindIdentifier'
13:24:59 extension StringProtocol {
13:24:59           ^
13:24:59 /Users/buildnode/jenkins/workspace/swift-PR-macos/branch-main/swift-docc/Sources/SwiftDocC/Infrastructure/Symbol Graph/SymbolGraphRelationshipsBuilder.swift:152:81: error: referencing operator function '==' on 'StringProtocol' requires that 'SymbolGraph.Symbol.KindIdentifier' conform to 'StringProtocol'
13:24:59             if let rawSymbol = conformingNode.symbol, rawSymbol.kind.identifier == SymbolGraph.Symbol.Kind.Swift.protocol.rawValue {
13:24:59                                                                                 ^
13:24:59 Swift.StringProtocol:1:11: note: where 'Self' = 'SymbolGraph.Symbol.KindIdentifier'
13:24:59 extension StringProtocol {
13:24:59           ^

@lorentey
Copy link
Member Author

@swift-ci smoke test macOS platform

@lorentey
Copy link
Member Author

It looks like the DocC build issue was resolved by swiftlang/swift-docc#30.

@lorentey lorentey merged commit a2c9bc6 into swiftlang:main Nov 13, 2021
@lorentey lorentey deleted the label-validation-tests branch November 13, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants