Skip to content

Avoid #include <sstream> when not needed #40174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2021
Merged

Avoid #include <sstream> when not needed #40174

merged 1 commit into from
Nov 14, 2021

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

compnerd
compnerd approved these changes Nov 14, 2021
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, always good to remove c++ header includes.

@kubamracek kubamracek merged commit 5b32645 into swiftlang:main Nov 14, 2021
@kubamracek kubamracek deleted the no-sstream branch November 14, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@mikeash mikeash Awaiting requested review from mikeash

@al45tair al45tair Awaiting requested review from al45tair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubamracek @compnerd