Skip to content

[test][stdlib] Beef up Unicode.Scalar.Properties testing #40181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Nov 15, 2021

Right now, this is depending on #39597 landing first before testing this PR.

Adds a new test that reads the Unicode data files and compares answers for all scalar properties for every scalar. Obviously this is marked as a long_test, but in this way we can ensure that we aren't returning incorrect information with our data structures storing the Unicode data.

@Azoy Azoy force-pushed the testing-unicode-scalar-props branch from 30fb4c3 to b2b0af4 Compare December 20, 2021 23:09
@Azoy
Copy link
Contributor Author

Azoy commented Dec 20, 2021

@swift-ci please smoke test

@Azoy Azoy marked this pull request as ready for review December 20, 2021 23:10
@Azoy Azoy requested a review from milseman December 20, 2021 23:10
Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test looks great to me. Let's make sure we run it at the right granularity level. This is a fairly exhaustive programmatic test that is very useful before publishing toolchains or releases, but shouldn't impact anyone's development cycle.

oops forgot to put this back in and 5.6
@Azoy Azoy force-pushed the testing-unicode-scalar-props branch from b2b0af4 to edc5d88 Compare December 20, 2021 23:21
@Azoy
Copy link
Contributor Author

Azoy commented Dec 20, 2021

@swift-ci please smoke test

@Azoy
Copy link
Contributor Author

Azoy commented Dec 21, 2021

@swift-ci please smoke test

@Azoy Azoy merged commit 27ec10e into swiftlang:main Dec 22, 2021
@Azoy Azoy deleted the testing-unicode-scalar-props branch December 22, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants