[CSGen] Rework nil-coalescing operator handling in LinkedExprAnalyzer
#40214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `LinkedExprAnalyzer` to capture `??` operator and walk into its arguments because they could have valuable type information, but don't attempt to favor or link operators if `??` is present in a chain. Resolves: rdar://85277993
hborla
approved these changes
Nov 17, 2021
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows platform |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
LinkedExprAnalyzerto capture??operator and walk intoits arguments, because they could have valuable type information,
but don't attempt to favor or link operators if
??is present in a chain.Resolves: rdar://85277993