Include missing _getMainExecutor and _asyncMainDrainQueue in concurrency swiftinterface
#40221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The asyncMainDrainQueue is also declared `internal`, so it won't show up in the swiftinterface file. The expected declaration is: ``` @available(SwiftStdlib 5.5, *) @_silgen_name("swift_task_asyncMainDrainQueue") internal func _asyncMainDrainQueue() -> Never ```
getMainExecutor and asyncMainDrainQueue function declarations are needed to compile programs with the asyn-main function. The functions are declared internal, so they don't show up in the swift interface files.
|
@swift-ci please test |
DougGregor
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the API are in swift modules and in the standard library, they are not included in the swift interface file because they are internal. By marking the API as
@usableFromInline, they are included in the swift interface file.I added the ability to generate the declaration for
_getMainExecutorin #39941, I missed_asyncMainDrainQueue, so I've added that here. It shouldn't be necessary when the compiler is paired up with the correct version of the standard library, but it appears that's not always happening, so this is taking care of both of those issues.I've manually inspected the resulting swift interface file generated locally and have ensured that the correct declarations are emitted: