[stdlib] Make the rest of the scalar properties native #40233
Conversation
|
@swift-ci please test |
|
@swift-ci please clean test Windows |
| // Name aliases are only found with correction attribute. | ||
| guard components[2] == "correction" else { | ||
| continue | ||
| } |
There was a problem hiding this comment.
Could the alternate name alias (for ZERO WIDTH NO-BREAK SPACE) also be included?
FEFF;BYTE ORDER MARK;alternate
And possibly the control name aliases? Although how would you choose which one to include?
0009;CHARACTER TABULATION;control
0009;HORIZONTAL TABULATION;control
| } | ||
| return codeUnits.withUnsafeBufferPointer { String._uncheckedFromUTF16($0) } | ||
|
|
||
| return result |
|
@swift-ci please test |
Azoy
force-pushed
the
finish-scalar-properties
branch
from
2ee54a9 to
9e742a2
Compare
|
@swift-ci please test |
|
Build failed |
| } | ||
| return codeUnits.withUnsafeBufferPointer { String._uncheckedFromUTF16($0) } | ||
|
|
||
| return result |
There was a problem hiding this comment.
I wonder if we have good benchmark coverage for this. This could be a nice improvement.
| case 1: | ||
| self = .digit | ||
| case 2: | ||
| self = .decimal |
There was a problem hiding this comment.
We have lots of sets of magic numbers that are coordinated with the data files. I do wonder if it makes sense to have a C header with constants in it...
fix special mappings fix bug
Azoy
force-pushed
the
finish-scalar-properties
branch
from
9e742a2 to
a8ae6e7
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test Linux |
…lang#40233)" This reverts commit ac6c08f.
This PR implements all of the
Unicode.Scalar.Propertiesin our native data.