[CMake] Also treat builds in Playgrounds trains as "Xcode" builds. #40250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These builds are meant to be as close to Xcode train builds as possible, so it makes sense to treat them this way instead of letting them be treated as OS builds or making a new kind of B&I build for them. Playgrounds trains are identifiable via the `RC_PLAYGROUNDS` environment variable being set to `YES`; if that isn't set, then it's not a Playgrounds train. This addresses <rdar://problem/85511438>.
|
@swift-ci Please test |
mikeash
approved these changes
Nov 19, 2021
cwakamo
deleted the
eng/PR-85511438-treat-Playgrounds-trains-like-Xcode-trains
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These builds are meant to be as close to Xcode train builds as possible, so it
makes sense to treat them this way instead of letting them be treated as OS
builds or making a new kind of B&I build for them.
Playgrounds trains are identifiable via the
RC_PLAYGROUNDSenvironmentvariable being set to
YES; if that isn't set, then it's not a Playgroundstrain.
This addresses rdar://problem/85511438.