IRGen: do not mark AFP as const #40292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Windows platform |
We were not marking the async function pointer as constant but adding it to the `.rdata` section which the Windows linker helped identify as a problem: we were adding data with "rw" to a section that is expected to be "rd". Marking the data as constant results in error propagation breaking (presumably due to failure to materialize parameters properly as bindiff'ing the Concurrency library indicates that the functions are nearly identical with some argument loads elided). This repairs the emission of read/write data into the readonly section.
compnerd
force-pushed
the
constantinople
branch
from
d0d32b9 to
64d2d39
Compare
compnerd
changed the title
setTrueConst mark the variable as constant
|
@swift-ci please test |
|
Okay, further investigation results: the problem is that marking the AFP as constant allows LLVM to peer through the structure. Then, when IRGen'ing it will inline all the context to 32-bytes unconditionally dropping the AFP checks even on the generic parameter. The failing tests fortunately helped here - they happened to have a larger context size (e.g. async_taskgroup_throw_recover has 48 bytes). However, because we only allocated 32-bytes for the task, we now get corruption. |
|
CC: @aschwaighofer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not marking the async function pointer as constant but adding it
to the
.rdatasection which the Windows linker helped identify as aproblem: we were adding data with "rw" to a section that is expected to
be "rd". Marking the data as constant results in error propagation
breaking (presumably due to failure to materialize parameters properly
as bindiff'ing the Concurrency library indicates that the functions are
nearly identical with some argument loads elided). This repairs the
emission of read/write data into the readonly section.