libswift: replace use of std::string with char *
#40299
Conversation
This replaces the use of C++ interop with C bindings for the string bridging. This change ensures that the interop can be used on all platforms, including those where the ABI concerns with C++ have not yet been addressed.
|
CC: @eeckstein @zoecarver |
|
@swift-ci please test |
|
Build failed |
|
Why not just revert f063701? |
There was a problem hiding this comment.
Please do not merge this PR before we have a proper discussion about whether this is the right path to resolve the issues you're discussing.
What specific ABI issues are you seeing with std::string on Windows? For both ctors (which are not used in libSwift) and copy-ctors, we ask clang for the function signature/ABI to ensure that we match that and emit a thunk where needed.
If we're going to do this, I agree with Erik, let's use what was there before, it's much better (matches the other string bridging and is platform agnostic).
|
Okay, but we need to get this sorted out for now. Lets revert the other change for now. |
|
I have a PR for the revert (which is also need for unblocking CMO work): #40607 |
Sorry, I somehow missed this comment. @compnerd can you please explain the issue you're running into. I'd really like to avoid reverting this change. |
This replaces the use of C++ interop with C bindings for the string
bridging. This change ensures that the interop can be used on all
platforms, including those where the ABI concerns with C++ have not yet
been addressed.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.