Skip to content

[Sema] Made $main non-dynamic. #40315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Nov 29, 2021

Previously, it was possible for $main to be made dynamic by passing -enable-implicit-dynamic. That has always been a problem in asserts builds because a direct function_ref to $main is created in the main function. More recently, it has become a problem in non-asserts builds because the dynamic replacements are now in the IR module but are not in the TBD file.

Here, the function is marked as not dynamic.

rdar://84962693

Previously, it was possible for $main to be made dynamic by passing
-enable-implicit-dynamic.  That has always been a problem in asserts
builds because a direct function_ref to $main is created in the main
function.  More recently, it has become a problem in non-asserts builds
because the dynamic replacements are now in the IR module but are not in
the TBD file.

Here, the function is marked as not dynamic.

rdar://84962693
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4b8747e

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test linux platform

@nate-chandler nate-chandler merged commit 6fa89b7 into swiftlang:main Nov 30, 2021
@nate-chandler nate-chandler deleted the rdar84962693 branch November 30, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants