Skip to content

Add a crash reproducer for rdar://85843677 #40322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

kubamracek
Copy link
Contributor

#39989 seems to introduce a crash in the testcase being added by this PR. Since it's getting reverted via #40321, let's add the testcase to force the crash to get fixed before the next attempt to re-land the changes.

@kubamracek kubamracek requested a review from xedin November 30, 2021 04:02
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please move this from test/Constraints to validation-test/Sema/validation-test/Sema/type_checker_crashers_fixed as rdar85843677.swift? That's were we are adding all of the fixed crashers

@@ -0,0 +1,15 @@
// RUN: %target-typecheck-verify-swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit - you'd have to add not I think here since I have landed my revert so this would no longer crash.

@kubamracek
Copy link
Contributor Author

Accidentally closed - reopened in #40327.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants