Give a proper error when a member type is inaccessible. #4033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
| @@ -785,6 +785,36 @@ static Type diagnoseUnknownType(TypeChecker &tc, DeclContext *dc, | |||
| } | |||
|
|
|||
| // Qualified lookup case. | |||
|
|
|||
| // Try ignoring access control. | |||
| NameLookupOptions lookupOptions = defaultMemberLookupOptions; | |||
There was a problem hiding this comment.
Since this is repeated twice, do you think it makes sense to define a new memberTypeLookupOptions or similar?
There was a problem hiding this comment.
The rest of the options are slightly different. Really it probably makes more sense to pass it down from outside.
|
@swift-ci test linux |
This doesn't yet cover top-level types or top-level non-type values, but it's a start. Part of rdar://problem/27663403.
jrose-apple
force-pushed
the
error-on-private-member-types
branch
from
0e742fc to
623fdd1
Compare
|
Updated per Slava's feedback. This should be NFC, so just smoke testing. @swift-ci Please smoke test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Aug 8, 2016
This doesn't yet cover top-level types or top-level non-type values, but it's a start. Part of rdar://problem/27663403. (cherry picked from commit 8d95352)
phausler
pushed a commit
to phausler/swift
that referenced
this pull request
Aug 8, 2016
This doesn't yet cover top-level types or top-level non-type values, but it's a start. Part of rdar://problem/27663403.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't yet cover top-level types or top-level non-type values, but it's a start.
Part of rdar://problem/27663403.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.