Adding optional message to _unavailableFromAsync
#40378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test Linux |
etcwilde
force-pushed
the
ewilde/concurrency/unavailablefromasync-messages
branch
from
e3deaca to
043d391
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test Linux |
|
@swift-ci please test |
|
@swift-ci please clean test Linux |
DougGregor
reviewed
Dec 8, 2021
| @@ -4719,7 +4719,7 @@ ERROR(async_named_decl_must_be_available_from_async,none, | |||
| "asynchronous %0 %1 must be available from asynchronous contexts", | |||
| (DescriptiveDeclKind, DeclName)) | |||
| ERROR(async_unavailable_decl,none, | |||
| "%0 %1 is unavailable from asynchronous contexts", (DescriptiveDeclKind, DeclBaseName)) | |||
| " %0 %1 is unavailable from asynchronous contexts%select{|; %3}2", (DescriptiveDeclKind, DeclBaseName, bool, StringRef)) | |||
There was a problem hiding this comment.
Hate to point it out, but there's an extra space at the beginning here
There was a problem hiding this comment.
Oh that's where that space went. Nice catch. Thanks.
Adding the ability to add an optional message to the unavailable from async attribute. This can be used to indicate other possible API to use, or help explain why it's unavailable.
Adding nice error messages for when things go wrong.
etcwilde
force-pushed
the
ewilde/concurrency/unavailablefromasync-messages
branch
from
eba737a to
34fc8cd
Compare
|
@swift-ci please test |
|
@swift-ci please clean test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding an optional
messagefield to the_unavailableFromAsyncattribute so that API devs can provide more information about how to proceed. Not all API necessarily have a replacement so this is an optional parameter.Something like a "renamed" declaration would be nice, though
renameddoesn't make sense since we aren't renaming the API.Commits will get cleaned up once #40149 merges.