[frontend] Fix TBD validation almost always done for modules #40414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Good catch. Could you provide a quick regression test that builds a SIB file and tries to pull it in through the frontend as an input? |
The logic to do or not the validation of TBD against IR was incorrect. In the case of modules, the comment described what was supposed to happen (skipping the validation if the module had SIB files), but the code was returning if the module had or not SIB files, which would have returned true for any module without SIB files without checking if the compiler was build in a debug configuration or not. This was only visible in the case of non-debug builds, and it only appeared for us in a convoluted mix of optimized builds with -enable-testing on some modules.
drodriguez
force-pushed
the
tbd-validation-modules
branch
from
2cfc4be to
8a0e512
Compare
|
Added a small check that creates a module from a SIB file and a non-SIB module and checks that independently if the validation is performed, SIL can be generated. @swift-ci please smoke test |
|
@swift-ci please test Windows platform |
|
@CodaFi: can you check if the added test was what you had in mind? (if not, can you point out to a test that I can look as a template?) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to do or not the validation of TBD against IR was incorrect.
In the case of modules, the comment described what was supposed to
happen (skipping the validation if the module had SIB files), but the
code was returning if the module had or not SIB files, which would have
returned true for any module without SIB files without checking if the
compiler was build in a debug configuration or not.
This was only visible in the case of non-debug builds, and it only
appeared for us in a convoluted mix of optimized builds with
-enable-testing on some modules.