-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[test] Fix test failure on non-x86_64 targets in failed-clang-module test case. #4043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
|
62e85e2
to
0d55bdd
Compare
@jrose-apple Thank you! I didn't know that. |
@swift-ci Please test |
Linux CI bot substituted |
It seems, only I'm not sure what should I do. |
I think marking the test as |
0d55bdd
to
bedd93d
Compare
Added @swift-ci Please test |
Agreed, but it would be great to properly set |
Oh, certainly. But right now we're replicating the driver logic for every architecture we care about, and doing that for Linux seems problematic. (The reason the names don't match up, by the way, is because iOS allows armv7 and armv7s modules to coexist and interoperate.) |
Thanks @rintaro ! |
What's in this pull request?
Use%target-cpu
instead ofx86_64
in litRUN:
scriptUse
%target-swiftmodule-name
instead ofx86_64.swiftmodule
in litRUN:
scriptFixes:
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.