Make caching the typeref builder cache lazier #40432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
adrian-prantl
approved these changes
Dec 7, 2021
|
|
||
| // Index of the next Reflection Info that should be processed. | ||
| // This assumes that Reflection Infos are never removed from the vector. | ||
| size_t CurrentReflectionInfoIndex = 0; |
There was a problem hiding this comment.
Does FirstUnprocessedReflectionInfoIndex convey the intention better?
| @@ -643,6 +643,10 @@ class TypeRefBuilder { | |||
|
|
|||
| private: | |||
| std::vector<ReflectionInfo> ReflectionInfos; | |||
|
|
|||
| // Index of the next Reflection Info that should be processed. | |||
| // This assumes that Reflection Infos are never removed from the vector. | |||
mikeash
approved these changes
Dec 7, 2021
augusto2112
force-pushed
the
lazy-typeref-caching
branch
from
1dab116 to
d200a06
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when we have a cache miss on the typeref cache, we parse all the metadata that we know of, before querying the cache again. Change this to query for the typeref after parsing every reflection info. This will be especially useful for LLDB, as it uses a client server model, and parsing metadata may involve going through a (potentially slow network).
This PR also has an added benefit of not re-parsing metadata that was already parsed before, if, for example, a new image is loaded in between different typeref queries.