Skip to content

[Fix-it] Support defaulted and variadic arguments in renamed fix-it #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jrose-apple
Copy link
Contributor

  • Explanation: Our diagnostics for renamed functions was bailing out whenever any of the arguments were defaulted at the call site, leaving only a fix-it for the base name. If the base name was the same, this was especially confusing.
  • Scope: The code path affects all rename diagnostics that include parameters. Correct code should not be affected by this change.
  • Issue: SR-2264
  • Reviewed by: @jrose-apple (authored by @rintaro)
  • Risk: Low.
  • Testing: Added to existing compiler regression tests.

Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

[Fix-it] Support defaulted and variadic arguments in renamed fix-it
(cherry picked from commit 3db6fd2)
@jrose-apple jrose-apple added this to the Swift 3.0 milestone Aug 5, 2016
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

Approved by @tkremenek via email.

@jrose-apple jrose-apple merged commit 819cd0d into swiftlang:swift-3.0-branch Aug 5, 2016
@jrose-apple jrose-apple deleted the swift-3-rename-fixit-tupleshuffle branch August 5, 2016 21:08
kateinoigakukun pushed a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants