Convert Swift Differentiable Programming Implementation Overview to Markdown #40443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ammingImplementation.md
compnerd
requested changes
Dec 7, 2021
|
I’ll get to approving these requested changes as soon as possible. |
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
I was thinking of removing this since I didn't include it in the table of contents. Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
rxwei
reviewed
Dec 7, 2021
Co-authored-by: Richard Wei <[email protected]>
Co-authored-by: Richard Wei <[email protected]>
Update DifferentiableProgrammingImplementation.md
Co-authored-by: Saleem Abdulrasool <[email protected]>
compnerd
reviewed
Dec 8, 2021
compnerd
reviewed
Dec 8, 2021
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
Co-authored-by: Saleem Abdulrasool <[email protected]>
|
One more pending requested change before this can merge! |
rxwei
reviewed
Dec 8, 2021
Co-authored-by: Richard Wei <[email protected]>
|
This should be ready for merging now |
|
Thanks for addressing the comments. I'll give others (@dan-zheng, @BradLarson) some time to have a look before approving. |
rxwei
approved these changes
Dec 8, 2021
|
@swift-ci please smoke test and merge |
|
Finally! |
|
Sorry for the late review. The ported document looks good, thank you @philipturner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dan-zheng requested that I make this pull request to apple/swift. I converted a file linked as Swift documentation to Markdown. This is currently a Google Doc, which is less appropriate to collaborate on this setting, and has a pending request to turn it into Markdown.
I did the following in this PR:
DifferentiableProgrammingImplementation.mdindocs.DifferentiableProgrammingImplementationdirectory indocs/assetsand added two images.For the changes I made while converting from the Google Doc, see the original pull request to tensorflow/swift-apis.