[rebranch] Fix async-args.swift #40447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdar://82037718
|
@swift-ci please test |
|
It's likely we'll still get a failing build because of the racy async test, but we're just looking for @adrian-prantl sorry about the mess here - I had previously assumed this test was failing due to a bad merge, but it was in fact because were missing all those commits from stable/20211026. It should now be what's on |
|
Build failed |
|
Build failed |
|
Swift tests all passed, LLDB issue is fixed in swiftlang/llvm-project#3635 |
adrian-prantl
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bit of a confusing one caused by stable/20211026 missing commits.
test/DebugInfo/async-args.swiftwas updated in 2a74582 but since the corresponding LLVM change was missing, this was causing failures on rebranch. It was thus mostly reverted, which now causes a failure since the LLVM change is back.Cherry-pick the actual previous update to fix the test (again).