[move-function] Implement move function support for address only vars. #40453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have to make a few other changes to make this work for loadable vars, but I wanted to get this in. Behind a flag.
gottesmm
force-pushed
the
pr-a85fbe6f331638d8fc105031e934d0516c72122f
branch
from
e5b8714 to
2e018af
Compare
gottesmm
commented
Dec 7, 2021
| // Var // | ||
| ///////// | ||
|
|
||
| public func performMoveOnVar<T>(_ p: T) { |
There was a problem hiding this comment.
I deleted this since I am making separate test files for lets/vars since they are different use cases and are handled slightly differently.
|
Just to provide a little bit of context, I found that when I was looking at the codegen out of SILGen that SILGen was emitting code that used reinitialization via assign like operations (e.x.: store [assign], copy_addr [take]). I had to teach the memory analysis about this to ensure that we stopped propagating moves at that block. |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to make a few other changes to make this work for loadable vars, but I
wanted to get this in.
Behind a flag.