RequirementMachine: Protocol requirement signature minimization fixes #40465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
rqm-protocol-minimization-fixes
branch
from
f7880c4 to
169b941
Compare
…ules This is a source-level error, not an invariant violation. Instead, plumb a new hadError() flag, which in the future will assert if no diagnostic was produced.
…formanceRequirement()
When a rule is replaced by a rewrite path, if the rule is in context then every step of the replacement step is necessarily always in context. The only way new rules in empty context can be introduced by a replacement is if the original rewrite step being replaced had no context. Therefore, loops that do not contain rules in empty context will never provide any additional information during homotopy reduction.
…alized When a rewrite rule is replaced with a path containing ::Adjust, ::Decompose, ::ConcreteConformance or ::SuperclassConformance rewrite steps, the steps will get a non-zero EndOffset if the original rule appears in a step with a non-zero EndOffset. For this reason, these steps must work with a non-zero EndOffset, which primarily means computing correct offsets into the term being manipulated.
… conformances now
…ment-machine-protocol-signatures=verify for now
This doesn't actually matter, except to make the requirement machine minimization cross-checking work on highly-invalid test cases.
This doesn't actually matter, except to make requirement machine minimization cross-checking work on highly invalid code with duplicate associated type declarations in the same protocol.
slavapestov
force-pushed
the
rqm-protocol-minimization-fixes
branch
from
169b941 to
8a08872
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, more validation tests pass with -requirement-machine-protocol-signatures=verify.
There were a couple of highly-invalid cases where the requirement machine's result was more "correct", so I hacked the GSB just to make a few tests pass. If these GSB changes cause some unforseen breakage, they can be reverted separately without issue.
Also, a couple of optimizations to the homotopy reduction algorithm. It's still too slow.