Skip to content

[SIL] Reenable destroy hoisting under lexical lifetimes. #40477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nate-chandler
Copy link
Contributor

Until #40392 lands, run destroy hoisting with lexical lifetimes.

@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test

@nate-chandler nate-chandler requested a review from atrick December 9, 2021 00:09
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. But to get this merged you may need to disable the check in test_localVar_keepsObjectAliveBeyondCallToClassWithWeakReference. Destroy hoisting breaks the test.

@nate-chandler nate-chandler force-pushed the lexical-lifetimes/reenable-destroy-hoisting branch from 9ac4e85 to a43bdcd Compare December 9, 2021 16:21
@nate-chandler
Copy link
Contributor Author

@swift-ci please test and merge

Until swiftlang#40392 lands, run destroy
hoisting with lexical lifetimes.
@nate-chandler nate-chandler force-pushed the lexical-lifetimes/reenable-destroy-hoisting branch from a43bdcd to 59f3b37 Compare December 9, 2021 18:42
@nate-chandler
Copy link
Contributor Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit 6a75261 into swiftlang:main Dec 9, 2021
@nate-chandler nate-chandler deleted the lexical-lifetimes/reenable-destroy-hoisting branch July 5, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants