Regex literal runtime plumbing. #40487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
force-pushed
the
regex-integration-1
branch
2 times, most recently
from
7e8c1ac to
42234e9
Compare
|
@swift-ci please test |
hamishknight
reviewed
Dec 9, 2021
rxwei
force-pushed
the
regex-integration-1
branch
2 times, most recently
from
4d540c3 to
4e376cf
Compare
hamishknight
reviewed
Dec 9, 2021
rxwei
force-pushed
the
regex-integration-1
branch
from
4e376cf to
f6c3186
Compare
hamishknight
approved these changes
Dec 9, 2021
|
@swift-ci please test |
|
@swift-ci please test windows |
- Frontend: Implicitly import `_StringProcessing` when frontend flag `-enable-experimental-string-processing` is set. - Type checker: Set a regex literal expression's type as `_StringProcessing.Regex<(Substring, DynamicCaptures)>`. `(Substring, DynamicCaptures)` is a temporary `Match` type that will help get us to an end-to-end working system. This will be replaced by actual type inference based a regex's pattern in a follow-up patch (soon). - SILGen: Lower a regex literal expression to a call to `_StringProcessing.Regex.init(_regexString:)`. - String processing runtime: Add `Regex`, `DynamicCaptures` (matching actual APIs in apple/swift-experimental-string-processing), and `Regex(_regexString:)`. Upcoming: - Build `_MatchingEngine` and `_StringProcessing` modules with sources from apple/swift-experimental-string-processing. - Replace `DynamicCaptures` with inferred capture types.
rxwei
force-pushed
the
regex-integration-1
branch
from
f6c3186 to
05363cd
Compare
|
@swift-ci please test and merge |
|
This PR is causing Swift to fail to build on Windows: https://ci-external.swift.org/view/Pull%20Request/job/swift-PR-windows/19118 |
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
Dec 10, 2021
DougGregor
added a commit
that referenced
this pull request
Dec 10, 2021
Fix windows build failure from #40487.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_StringProcessingwhen frontend flag-enable-experimental-string-processingis set._StringProcessing.Regex<(Substring, DynamicCaptures)>.(Substring, DynamicCaptures)is a temporaryMatchtype that will help get us to an end-to-end working system. This will be replaced by actual type inference based a regex's pattern in a follow-up patch (soon)._StringProcessing.Regex.init(_regexString:).Regex,DynamicCaptures(matching actual APIs in apple/swift-experimental-string-processing), andRegex(_regexString:).Upcoming:
_MatchingEngineand_StringProcessingmodules with sources from apple/swift-experimental-string-processing.DynamicCaptureswith inferred capture types.