Skip to content

[Concurrency/Runtime] Implement function/continuation type generation… #40495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 10, 2021

… for AsyncSignature

AsyncFunctionTypeImpl has its type defaulted to TaskContinuationFunction
which is incorrect because it has to append arguments, result type and account
for throws bit.

These changes expand AsyncSignature with ContinuationType and expand FunctionType
to include all of the appropriate information.

… for `AsyncSignature`

`AsyncFunctionTypeImpl` has its `type` defaulted to `TaskContinuationFunction`
which is incorrect because it has to append arguments, result type and account
for throws bit.

These changes expand `AsyncSignature` with `ContinuationType` and expand `FunctionType`
to include all of the appropriate information.
@xedin xedin requested a review from rjmccall December 10, 2021 00:53
@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2021

@swift-ci please clean test

Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9a00b33

@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2021

@swift-ci please smoke test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2021

@swift-ci please test Linux platform

@xedin xedin merged commit be59474 into swiftlang:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants