[5.6] Revert "[SourceKit] Don't build an AST if no semantic info is requested" #40496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #40491 to
release/5.6
.Reverts #40353
The change actually wasn’t correct because we didn’t consider the following scenario:
key_enablesyntaxmap = key_enablesubstructure = key_enablediagnostics = 0
andsyntax tree transfer mode set to off
0,0
replace text request that hadkey_enablediagnostics = 1
. That request doesn’t cause the AST to rebuild but just returns the latest semantic information.With the PR that is being reverted we wouldn’t build an AST at all and thus we won’t have any diagnostics to return from the
0,0
replace text request.rdar://86289587