Skip to content

[Serialization] Fix deserialization crash occurring when a mixed framework fails to load its ObjC part. #4050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Aug 5, 2016

Reviewed by Jordan Rose.

Fixes crash with a case such as:

  • there is mixed framework A
  • swift module B depends on A and is built fine
  • there is a swift invocation that imports B but causes the ObjC part of A to fail to import
  • trying to serialize decls of B that depend on A will crash

rdar://27709042


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@akyrtzi
Copy link
Contributor Author

akyrtzi commented Aug 5, 2016

@swift-ci smoke test

@akyrtzi akyrtzi added this to the Swift 3.0 milestone Aug 5, 2016
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Aug 5, 2016

@swift-ci smoke test linux platform

1 similar comment
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Aug 5, 2016

@swift-ci smoke test linux platform

@tkremenek tkremenek merged commit 977e687 into swiftlang:swift-3.0-branch Aug 6, 2016
@akyrtzi akyrtzi deleted the deserialization-crash-3-27709042 branch August 6, 2016 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants