RequirementMachine: Diagnose non-confluent rewrite systems instead of asserting #40502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getFirstTypeRepr() asserts unless the RequirementRepr is a SameType requirement. For type requirements we need to call getSubjectTypeRepr().
… asserting We assert when building a rewrite system for an existing generic signature, or in AbstractGenericSignatureRequest, where there is no source location. In RequirementSignatureRequest and InferredGenericSignatureRequest we now produce a diagnostic.
Filter out trivial overlaps where a rule overlaps entirely with itself before looking at CheckedOverlaps. Otherwise, we'll miss overlaps where a rule overlaps with itself at a non-zero position.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.