[stdlib] Use Apple's PUA Unicode data #40526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
milseman
approved these changes
Dec 13, 2021
There was a problem hiding this comment.
This LGTM for now.
I do think we want to eventually (maybe soon) consider getting these data files and the generator script out of the normal Swift repo (somehow syncing the magic numbers). This will become a bigger and bigger deal if/when we want to support multiple versions of the data files, which it really seems like we'll want to consider, at the very least for testing purposes.
|
@swift-ci please test windows platform |
Azoy
added a commit
to Azoy/swift
that referenced
this pull request
Jan 7, 2022
[stdlib] Use Apple's PUA Unicode data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple has defined PUA (Private Use Area) scalars with specific Unicode data. Use that on Apple platforms and default to base Unicode data everywhere else.