RequirementMachine: Refactor nested type concretization #40536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith the same concrete type
… rules Previously we did this when adding new concrete type rules, but we don't have a complete rewrite system at that point yet, so there was no guarantee concrete substitution terms would be canonical. Now, perform simplification in a post-pass after completion, at the same time as simplifying rule right hand sides. Rewrite loops are recorded relating the original rule with the simplified substitutions.
This isn't quite right, because we really want the longer (more specific) of the two rules to be conflicting, not the most-recently added rule.
…tizeNestedTypesFromConcreteParent()
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.