Increase the amount of memory we allow the constraint solver to use. #4054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various changes throughout the compiler and libraries appear to have resulted in an increase in memory usage in the constraint solver since Swift 2.2. This is a stop-gap measure to allow more expressions to compile while the expression type checker is being improved. We've seen several cases where even a modest increase allows things that compiled with Swift 2.2 to continue to compile (albeit with generally longer compile times). (cherry picked from commit 8886f77)
|
@swift-ci Test. |
|
@DougGregor Can you review for swift-3.0-branch? |
|
LGTM |
|
Looks like we hit the same Linux builder issue as #4053 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Cherry pick a change from master to swift-3.0-branch to increase the amount of memory we allow the constraint solver use.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
Various changes throughout the compiler and libraries appear to have
resulted in an increase in memory usage in the constraint solver since
Swift 2.2.
This is a stop-gap measure to allow more expressions to compile while
the expression type checker is being improved.
We've seen several cases where even a modest increase allows things that
compiled with Swift 2.2 to continue to compile (albeit with generally
longer compile times).
(cherry picked from commit 8886f77)