RequirementMachine: Implement minimization for concrete nested type requirements #40543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe concretization
…::simplifySubstitution()
… the GSB got it wrong These fail with -requirement-machine-protocol-signatures=verify because the GSB produces incorrect output. Enable the requirement machine unconditionally for these tests, bypassing verification. A new file test/Generics/same_type_requirements_in_protocol.swift contains reduced versions of all of the failures, with FileCheck used to confirm the exact requirement signature output.
slavapestov
force-pushed
the
rqm-type-witness-minimization
branch
from
922c46c to
2441e68
Compare
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following protocol:
The requirements
T : SequenceandT == Array<Int>together imply thatT.Element == Int. When property map construction adds this rule while walking nested types of conformances, we now record a rewrite path that relates this rule with the concrete conformance rule. This allows the nested type rules to be dropped from the minimized signature.There are other cases where the property map still records new rules without a rewrite path. For now, these rules are never minimized away. The goal is to never do this; eventually we will assert that new rules recorded after completion always have a rewrite path relating them to existing rules.