[IDE] Only consider synthesized extensions when in the same module #40566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
bnbarham
force-pushed
the
synthesized-harmony
branch
from
31b37b9 to
f8dc8b4
Compare
|
@swift-ci please test |
rintaro
reviewed
Dec 16, 2021
rintaro
reviewed
Dec 16, 2021
|
@nkcsgexi it'd be good to get your opinion on this one, do you know why we were grabbing the extended nominal to find the group name? |
Only declarations in the same module as synthesized extension's target are placed within a synthesized extension. We should thus not add "::SYNTHESIZED::" to the USR if the given declaration is in a different and. As an example, `Foundation` adds a method `components(separatedBy:)` to `String` through an extension on `StringProtocol`. But since it is within `Foundation` and not `Swift` it will *not* be in a synthesized extension of `String` or `StringProtocol`. So it should not have "::SYNTHESIZED::" added and should also not being in the `String` group. Resolves rdar://71355632.
bnbarham
force-pushed
the
synthesized-harmony
branch
from
f8dc8b4 to
bf0bcfa
Compare
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
nkcsgexi
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only declarations in the same module as synthesized extension's target
are placed within a synthesized extension. We should thus not add
"::SYNTHESIZED::" to the USR if the given declaration is in a different
and.
As an example,
Foundationadds a methodcomponents(separatedBy:)toStringthrough an extension onStringProtocol. But since it iswithin
Foundationand notSwiftit will not be in a synthesizedextension of
StringorStringProtocol. So it should not have"::SYNTHESIZED::" added and should also not being in the
Stringgroup.Resolves rdar://71355632.