Skip to content

[5.6] Fully Check Decls in Result Builders #40588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Dec 16, 2021

Cherry picked from #40512


In particular, this turns redeclaration checking on for variables in
pattern bindings.

rdar://86566912

@CodaFi CodaFi changed the title Fully Check Decls in Result Builders [5.6] Fully Check Decls in Result Builders Dec 16, 2021
@CodaFi CodaFi requested a review from hborla December 16, 2021 09:49
@CodaFi CodaFi added the r5.6 label Dec 16, 2021
@CodaFi
Copy link
Contributor Author

CodaFi commented Dec 16, 2021

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 12ced3102b41c3fdd15bf17a91823063cd5bf2b9

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 12ced3102b41c3fdd15bf17a91823063cd5bf2b9

In particular, this turns redeclaration checking on for variables in
pattern bindings.

rdar://85784090
@CodaFi
Copy link
Contributor Author

CodaFi commented Dec 16, 2021

Wow, this picked the wrong version. Let's try that again.

@CodaFi CodaFi force-pushed the every-day-and-twice-on-sundays branch from 12ced31 to d7958fa Compare December 16, 2021 16:33
@CodaFi
Copy link
Contributor Author

CodaFi commented Dec 16, 2021

@swift-ci test

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for5.6! It would be great (on main) to simplify finishPatternBindingDecl and just target for PatternBindingDecl there directly instead of its individual components.

@CodaFi
Copy link
Contributor Author

CodaFi commented Dec 16, 2021

#40592

@CodaFi CodaFi merged commit 27dc562 into swiftlang:release/5.6 Dec 16, 2021
@CodaFi CodaFi deleted the every-day-and-twice-on-sundays branch December 16, 2021 22:10
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.6 labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants