Add some availability attributes for UnsafePointer conversion. #4064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces some important diagnostics to help migration. Some of the diagnostics that we would like to provide are impossible on a generic class because they introduce ambiguity. Renaming UnsafePointer<Void> to UnsafeRawPointer makes extensions and global operators ambiguous. We would also like to provide this fix-it on conversion from UnsafePointer<Void> or UnsafeRawPointer to UnsafePointer<T> with this message: Conversion restricted. Use 'assumingMemoryBound(to:)' or 'bindMemory(to:capacity:)'}} However, that introduces ambiguous overloads that defeat other diagnostics.
|
@swift-ci Please smoke test and merge. |
|
CI testing failed on OS X because of timeout checking out sources from GitHub. |
kateinoigakukun
added a commit
that referenced
this pull request
Aug 31, 2022
Fix build issues when merging upstream `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces some important diagnostics to help migration.
Some of the diagnostics that we would like to provide are impossible
on a generic class because they introduce ambiguity.
Renaming
UnsafePointer<Void>toUnsafeRawPointermakes extensions andglobal operators ambiguous.
We would also like to provide a fix-it on conversion from
UnsafePointer<Void>orUnsafeRawPointertoUnsafePointer<T>with this message:
Conversion restricted. Use 'assumingMemoryBound(to:)' or 'bindMemory(to:capacity:)'}}However, that introduces ambiguous overloads that defeat other diagnostics.