test: enable SILOptimizer.definite-init-wrongscope #40676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was matching the wrong `throw` as the scope was incorrect. Correct the scope which allows us to match the correct `throw` and enable the test on Windows. While here, add an additional check for the `destroy_addr`, `dealloc_stack` to match the regular exit which is duplicated in the throwing block. Add an additional check to ensure that we do not escape the bounds of the function. Thanks to @adrian-prantl for helping ensure that the changes here are valid! Fixes: SR-14267
adrian-prantl
approved these changes
Dec 22, 2021
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was matching the wrong
throwas the scope was incorrect. Correctthe scope which allows us to match the correct
throwand enable thetest on Windows.
While here, add an additional check for the
destroy_addr,dealloc_stackto match the regular exit which is duplicated in thethrowing block. Add an additional check to ensure that we do not escape
the bounds of the function.
Thanks to @adrian-prantl for helping ensure that the changes here are
valid!
Fixes: SR-14267
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.