Support @_predatesConcurrency on import declarations
#40679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ades (cherry picked from commit 0367213)
When diagnosing a `Sendable` violation, suggest the use of `@_predatesConcurrency` on the corresponding import to suppress those diagnostics. (cherry picked from commit 23cc638)
…e remark Rather than tacking the "add `@_predatesConcurrecy` to import" diagnostic on to the prior diagnostic as a note, make it its own remark. Then, ensure that we only emit this remark once per source file per imported module, so we're not overwhelming the user. (cherry picked from commit 2832aed)
(cherry picked from commit 7a3da5a)
We'll already suggest the addition of `@_predatesConcurrency` on an import to downgrade or silence `Sendable`-related diagnostics, so we'll be adding these to people's code. Over time, this attribute can go stale, if the imported module's adopt `Sendable`. When the attribute isn't doing anything, because it didn't suppress any `Sendable`-related diagnostics, suggest that it be removed. (cherry picked from commit 884e72a)
(cherry picked from commit ceedb01)
The change to add the `import` keyword location to AttributedImport also removed the module name location in UnboundImport. However, we want to keep both locations, for different diagnostic reasons, so reinstate the module name location. (cherry picked from commit 7552cf9)
…ports (cherry picked from commit 58c62eb)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
@_predatesConcurrencyimport declaration suppresses or downgradesSendable-related diagnostics, providing a way to more smoothly adopt concurrency even when one depends on modules that have yet to adoptSendable. Allow@_predatesConcurrencyimport declarations and provide them with the appropriate semantics:@_predatesConcurrency importof a moduleXsuppressesSendablediagnostics for nominal types defined inX.@_predatesConcurrency importof a moduleXdowngradesSendablediagnostics for nominal types defined inXto warnings.When we emit a
Sendable-related diagnostic for a nominal type outside of the current module, produce a remark that suggests@_predatesConcurrencyon the corresponding import to silence the diagnostic, but only do this once per file. This will help folks makeSendablediagnostics more manageable. When a@_predatesConcurrencyattribute on an import isn't doing anything (because there were no failedSendablechecks from that module), emit a remark that removes the now-unnecessary@_predatesConcurrency.Implements rdar://84449015.