Add a comment to UnsafePointer assignment. #4070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// type `Pointee`. | ||
| /// - Precondition: the pointee has been initialized with an | ||
| /// instance of type `Pointee` unless this is an assignment into | ||
| /// `pointee` and `Pointee` is a trivial type. |
There was a problem hiding this comment.
You ought to be able to doc-comment getters and setters separately, but I doubt our tooling can do anything useful with that. @natecook1000 should probably figure out the phrasing here; "this" doesn't seem like the right word to me.
Initializing trivial types via assignment is allowed by convention, so make it official.
|
@swift-ci smoke test OS X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing trivial types via assignment is allowed by convention,
so make it official.