[Sema] Avoid misleading diagnostics for incomplete enum computed properties #40705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
LucianoPAlmeida
force-pushed
the
SR-15657-diag-enum-cp
branch
from
3c26b8e to
a5c26ce
Compare
xwu
reviewed
Dec 28, 2021
LucianoPAlmeida
force-pushed
the
SR-15657-diag-enum-cp
branch
from
a5c26ce to
b87244b
Compare
|
@swift-ci Please smoke test |
LucianoPAlmeida
force-pushed
the
SR-15657-diag-enum-cp
branch
from
34df035 to
af46849
Compare
|
@swift-ci Please smoke test |
LucianoPAlmeida
force-pushed
the
SR-15657-diag-enum-cp
branch
from
af46849 to
467521c
Compare
|
@swift-ci Please smoke test |
LucianoPAlmeida
force-pushed
the
SR-15657-diag-enum-cp
branch
from
467521c to
74f8bb0
Compare
LucianoPAlmeida
force-pushed
the
SR-15657-diag-enum-cp
branch
from
74f8bb0 to
29879ea
Compare
|
@LucianoPAlmeida This is in my queue, going to take a look on Monday. |
Thank you @xedin =] |
xedin
approved these changes
Jan 10, 2022
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just avoid a misleading diagnostic for incomplete enum computed properties. We had already a solution applied for extensions so this patch was simply apply to enum as well.
Resolves SR-15657.