[ConstraintSystem] SE-0326: Temporarily prevent multi-statement closure inference in result builder contexts #40708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esult builder context
…erence` Instead of checking the frontend flag directly, let's use dedicated method on a constraint system to determine whether closure did participate in inference or not.
…re inference in result builder contexts Multi-statement closure inference doesn't play well with result builders at the moment because it expects all of the information from the parent statements to be inferred before solver starts working on the body of a nested closure. Let's prevent inference for nested multi-statement closures until result builders are ported to use conjunctions and solve the body incrementally top-down instead of in one shot.
These are just invariant checks which will become obsolete as soon as multi-statement closure inference is enabled by default.
…t closures This test-case used to crash with multi-statement closure inference enabled in result builder contexts.
|
@swift-ci please clean test |
|
Build failed |
|
@swift-ci please test Linux platform |
|
@swift-ci please test Windows platform |
hborla
approved these changes
Jan 6, 2022
xedin
added a commit
to xedin/swift
that referenced
this pull request
Apr 4, 2022
… builder context This is a follow-up to swiftlang#40708 which only considers closures, but it missed the case when builder is applied to function body - in such cases the declaration context is going to be a function/getter declaration. Resolves: rdar://91150414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-statement closure inference doesn't play well with result builders
at the moment because it expects all of the information from the parent
statements to be inferred before solver starts working on the body of a
nested closure. Let's prevent inference for nested multi-statement closures
until result builders are ported to use conjunctions and solve the body
incrementally top-down instead of in one shot.