-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Move more Standard Library options to dedicated file #40723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move more Standard Library options to dedicated file #40723
Conversation
This addresses most of the options with computed defaults. Addresses rdar://86723940
@swift-ci please smoke test |
@swift-ci please test Apple Silicon |
@swift-ci please build toolchain |
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
@swift-ci Please ASAN test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This movement is fine, but it does make me wish for the names being more consistent internally. That is not your fault, and definitely beyond the scope of this change, but if you so feel inclined (as a separate change) ... ;-).
Also, thank you for taking the time to move the default value computation next to the option, I think that it makes this so much easier for longer term maintenance.
@swift-ci please smoke test |
@swift-ci please test Apple Silicon |
@swift-ci please build toolchain |
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
|
preset=stdlib_S_standalone_darwin_x86_64,build,test |
@swift-ci please test Windows |
@swift-ci please test Windows platform |
EDIT: spoke too soon, this does not happen in the newest run after swiftlang/llvm-project#3737 got merged. |
Linux runs are hitting the same failure as e.g. https://ci.swift.org/view/Packages/job/oss-swift-package-linux-ubuntu-16_04/6820/console
|
@swift-ci please build toolchain macOS |
@swift-ci please test Linux |
@swift-ci please build toolchain Linux platform |
macOS Toolchain Install command |
Linux Toolchain (Ubuntu 16.04) Install command |
@compnerd for now I made a note about renaming, not sure if/when I will be able to get to that |
This was missed when working on swiftlang#40723 and will prevent `SWIFT_STDLIB_HAS_ASL` having a wrong default.
This addresses most of the options with computed defaults.
Addresses rdar://86723940