Skip to content

Concurrency: avoid unnecessary dependency on LLVMSupport #40740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Jan 5, 2022

We do not have the llvm/Config/config.h header available in the forked
LLVMSupport library in our standard library packaging. This removes
that dependency by using the standard macro _POSIX_THREADS to detect
if we should use pthreads.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

We do not have the `llvm/Config/config.h` header available in the forked
LLVMSupport library in our standard library packaging.  This removes
that dependency by using the standard macro `_POSIX_THREADS` to detect
if we should use pthreads.
@compnerd compnerd requested a review from DougGregor January 5, 2022 17:00
@compnerd
Copy link
Member Author

compnerd commented Jan 5, 2022

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 5, 2022

Build failed
Swift Test OS X Platform
Git Sha - d30e196

@compnerd
Copy link
Member Author

compnerd commented Jan 7, 2022

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2022

Build failed
Swift Test OS X Platform
Git Sha - d30e196

@compnerd
Copy link
Member Author

compnerd commented Jan 7, 2022

11:02:15 2022-01-07 11:02:11.048 xcodebuild[67400:68895479]  DVTDownloadable: Failed to get authorization with error Error Domain=DVTDownloadableErrors Code=3 "The authorization was denied since no user interaction was possible." UserInfo={AuthorizationErrorCode=-60007, NSLocalizedDescription=The authorization was denied since no user interaction was possible.}
11:02:15 
xcodebuild: error: The authorization was denied since no user interaction was possible.

Seems unrelated to the change?

@compnerd
Copy link
Member Author

compnerd commented Jan 7, 2022

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2022

Build failed
Swift Test OS X Platform
Git Sha - d30e196

@compnerd
Copy link
Member Author

compnerd commented Jan 7, 2022

13:57:00 Failed Tests (3):
13:57:00   Swift(watchsimulator-i386) :: Interop/Cxx/class/protocol-conformance-irgen.swift
13:57:00   Swift(watchsimulator-i386) :: Interop/Cxx/templates/class-template-instantiation.swift
13:57:00   Swift(watchsimulator-i386) :: Interop/Cxx/templates/class-template-uninstantiatable-members-irgen.swift

@compnerd
Copy link
Member Author

compnerd commented Jan 7, 2022

@swift-ci please smoke test macOS platform

@compnerd compnerd merged commit 7972139 into swiftlang:main Jan 10, 2022
@compnerd compnerd deleted the unsupported branch January 10, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants