[Test] Checked variable lifetimes extend self. #40744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified that when a __consuming method calls a function which takes a closure that captures self weakly, self is not deallocated until the call returns. (Note that this is a behavioral change from what occurs when lexical borrow scopes are disabled; in that case, self is deallocated before the call to the function.)
|
@swift-ci please test |
Verified that lexical lifetimes DO NOT result in a method call to a weak reference resulting in a strong reference to the object. Consequently, even with lexical lifetimes enabled, it is still possible, within a single scope, for the first method call to an object weakly referenced to occur but for the second such call not to because the object will have been deallocated.
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test linux platform |
atrick
approved these changes
Jan 6, 2022
|
@Catfish-Man do these two tests, the sync test and the async test, match your expectations for behavior with lexical lifetimes enabled? |
|
@swift-ci please test |
nate-chandler
deleted the
lexical_lifetimes/test/verification/20220105/1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that when a __consuming method calls a function which takes a closure that captures self weakly, self is not deallocated until the call returns. (Note that this is a behavioral change from what occurs when lexical borrow scopes are disabled; in that case, self is deallocated before the call to the function.)