[5.6] [stdlib] Some fixes for scalar names #40759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please clean test macOS |
stephentyrone
approved these changes
Jan 10, 2022
[stdlib] Some fixes for scalar names
|
@swift-ci please test |
| @@ -159,6 +159,12 @@ func emitScalarNames( | |||
| } | |||
| } | |||
|
|
|||
| result += """ | |||
| #define NAMES_LAST_SCALAR_OFFSET \(nameBytes.count) | |||
There was a problem hiding this comment.
Normally in C I would define these in terms of the collection:
static const size_t _swift_stdlib_names_last_offset = sizeof _swift_stdlib_names / sizeof _swift_stdlib_names[0];
Given that they're programmatically generated, I'm ok with doing it they way you have it, so no need to fix this right now, but I generally prefer this style.
|
Build failed |
|
@swift-ci please clean test macOS |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry picks the changes made to fix getting some scalar names.
(Note this is dependent on #40758 )
(Cherry pick of #40644 for 5.6)