[SwiftSyntax] Avoid linking clangAST in SwiftSyntaxParserLib build #40762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Could we avoid linking |
`printClangDeclName` introduced another use of the clang AST in `swiftAST`, remove it by returning early if we are only building the parser library.
ahoppen
force-pushed
the
pr/build-clangast-for-parserlib
branch
from
ef71739 to
eecb741
Compare
ahoppen
changed the title
|
Yes, that’s definitely the cleaner solution. |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows |
akyrtzi
approved these changes
Jan 11, 2022
|
Windows failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printClangDeclNameintroduced another use of the clang AST inswiftAST, remove it by returning early if we are only building the parser library.