Introduce a mangling for multiple opaque types within the declaration. #40766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Qr` mangling is used to refer to the opaque type within the declaration that produces the opaque type. When there are multiple opaque types, e.g., due to structural or named opaque result types, it does not specify which of the opaque type parameters it refers to. Introduce a new mangling `QR INDEX` for opaque type parameters after the first, retaining the `Qr` mangling for the first opaque type parameter. This way, existing (non-structural) uses of opaque result types retain the same manglings, but uses of structural or named opaque result types (new features) will have distinct manglings. Note that this mangling within a declaration is only used for the declaration itself, and not for references to the opaque type of the declaration, so there is no impact on the runtime demangler.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Qrmangling is used to refer to the opaque type within thedeclaration that produces the opaque type. When there are multiple
opaque types, e.g., due to structural or named opaque result types, it
does not specify which of the opaque type parameters it refers to.
Introduce a new mangling
QR INDEXfor opaque type parameters afterthe first, retaining the
Qrmangling for the first opaque typeparameter. This way, existing (non-structural) uses of opaque result
types retain the same manglings, but uses of structural or named
opaque result types (new features) will have distinct manglings.
Note that this mangling within a declaration is only used for the
declaration itself, and not for references to the opaque type of the
declaration, so there is no impact on the runtime demangler.